Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve data upload performance #443

Closed
ichinaski opened this issue May 31, 2016 · 2 comments
Closed

Improve data upload performance #443

ichinaski opened this issue May 31, 2016 · 2 comments
Assignees
@ichinaski
Milestone
Akvo FLOW app 2.2.6

Comments

@ichinaski
Copy link
Contributor

Provide HttpURLConnection with byte array size, preventing all data being buffered on memory. This set up allows the data to be progressively streaming, improving the connection performance, and therefore reducing the risk of getting a memory error
@ichinaski ichinaski self-assigned this May 31, 2016
@ichinaski
Copy link
Contributor Author

Test plan:

  • Upload a few forms, containing 1+ image
    • All files should be uploaded no problem

ichinaski pushed a commit that referenced this issue May 31, 2016
[#443] Set content length, ensure upload stream
324710c
ichinaski pushed a commit that referenced this issue May 31, 2016
[#443] Avoid integer overflow
d613eac
@ichinaski ichinaski mentioned this issue Jun 2, 2016
Closed
3 tasks
@ichinaski ichinaski added this to the Akvo FLOW app 2.2.6 milestone Jun 2, 2016
@ichinaski
Copy link
Contributor Author

Test passes as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichinaski ichinaski

Labels
None yet
Projects
None yet
Milestone
Akvo FLOW app 2.2.6
Development

No branches or pull requests
1 participant
@ichinaski