Add akvo.lumen.dataset ns and remove lib/dataset-impl indirection #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangrammer
force-pushed
the
refactoring-dataset-nss
branch
from
bfeea13
to
727bf3c
Compare
tangrammer
changed the title
|
@iperdomo ready to review :) |
|
@iperdomo sorry wait one minute to review, i'll move lib/dataset.clj to a.l.dataset too |
Following same pattern as akvo.lumen.transformation
tangrammer
force-pushed
the
refactoring-dataset-nss
branch
from
7d0c698
to
45b9adb
Compare
|
LGTM waiting for the builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus
datasetdata structure is shared in almost all lumen code we add in this PR a new namespace for grouping common functionality and to associate upcomming specs related