Download option for visualisations and dashboards (connect #952) #1586

finnfiddle · 2018-08-01T12:22:10Z

Update release notes if necessary

…shboards-#952 * develop: Add more details about how retrieving values Refactor: Fix indentation Use `concat` instead of `||` in sql update. Relates to #1517 Add documentation on how to create new tenant #1514 Add documentation on how to create new tenant #1514 [#1408] Fix bug in raster import failure case [#1408] Clean up unsuccessful raster imports better [#1408] Client par of delete pending rasters WIP [#1408] Delete pending datasets WIP # Conflicts: # client/package-lock.json

Adapt backend env vars

kardan

Looks like we miss translation strings, seeing:
[React Intl] Missing message: "save_your_visualisation_before_exporting" for locale: "en"

kardan · 2018-08-01T12:59:40Z

backend/resources/akvo/lumen/system.edn

@@ -107,6 +107,7 @@
   :sentry-backend-dsn sentry-backend-dsn
   :flow-api-url flow-api-url
   :windshaft-url "http://localhost:4000"
+   :exporter-api-url "http://localhost:3001"


Should use bound symbol from config.clj

kardan · 2018-08-01T13:00:21Z

backend/src/akvo/lumen/config.clj

@@ -24,6 +24,7 @@
   'email-password (:lumen-email-password env)
   'email-user (:lumen-email-user env)
   'encryption-key (:lumen-encryption-key env)
+   'exporter-api-url "http://localhost:3001"


Should use env var or fallback to default as in (:exporter-api-url env "http://localhost:3001")

… and 'Download-option-for-visualisations-and-dashboards-#952' of github.com:akvo/akvo-lumen into Download-option-for-visualisations-and-dashboards-#952 * 'Download-option-for-visualisations-and-dashboards-#952' of github.com:akvo/akvo-lumen: Fix backend env vars * 'Download-option-for-visualisations-and-dashboards-#952' of github.com:akvo/akvo-lumen: Fix backend env vars

dlebrero · 2018-08-01T15:01:28Z

exporter/Dockerfile

@@ -0,0 +1,14 @@
+FROM zenato/puppeteer


Can we have a more specific version instead of latest?

I'm not sure there are any other tags, see https://hub.docker.com/r/zenato/puppeteer/tags/

I see there are plenty of puppeteer images. See https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=puppeteer&starCount=0.
The most popular one has tags.

I first went with the most popular one alekzonder/puppeteer but it uses an outdated version of puppeteer. Hence my choice. But the 2nd one could work because it uses the latest puppeteer - https://hub.docker.com/r/buildkite/puppeteer/. Will try now

… of github.com:akvo/akvo-lumen into Download-option-for-visualisations-and-dashboards-#952 * 'Download-option-for-visualisations-and-dashboards-#952' of github.com:akvo/akvo-lumen: Add `dev` env var

… of github.com:akvo/akvo-lumen into Download-option-for-visualisations-and-dashboards-#952 * 'Download-option-for-visualisations-and-dashboards-#952' of github.com:akvo/akvo-lumen: [#952] Silent cypress npm install [#952] Upgrade Cypress and quiet install output [#952] Enabled first Cypress tests [#952] Temporary disable cypress test

… and 'Download-option-for-visualisations-and-dashboards-#952' of github.com:akvo/akvo-lumen into Download-option-for-visualisations-and-dashboards-#952

kardan · 2018-08-16T04:14:33Z

Since this feature uses a new exporter service we need to make sure to deploy that in the k8s environment.

kardan · 2018-08-16T05:38:23Z

Todo:

Allow only authenticated requests
Update build and deploy scripts to handle the new service

First cut on not initialising a Keycloak session using token & refresh token but using the given token.

…shboards-#952 * develop: (55 commits) Disable *again* update for datasets coming from Data files [#1562] Fix query [#1638] Drop dataset source column [#1638] Select data_source.spec instead of dataset.source [#1638] [#1642] Upgrade to latest Windshaft image Revert isUpdatable logic Maps show small on shared link #1632 #1576 fixed rich text styling issues rich text editor fixes #1576 Use proper visualizable metadata in legend [client] [#1579] More translations [i18n] Set state.error=null on 200 http status Improve UI styling and translations Improvements [#1626] && Manage 404 backend http response Add "unit" to caddisfly "name" response Add aws url to caddisfly images [#1571] Tidy up multiple-column details response [#1571] inc z-index over maximum found in lumen css [#1561] Avoid add-to-collection opt in case of failing dataset [#1546] Disable update for datasets coming from Data files [#1562] ... # Conflicts: # backend/resources/akvo/lumen/system.edn # client/e2e-test/Dockerfile # client/package-lock.json # client/src/components/dashboard/DashboardEditor.jsx # client/src/translations/en.json # client/src/translations/es.json

…shboards-#952

kardan · 2018-09-17T07:01:10Z

Adding a viz to a Dashboard generates the following browser console warning:

warning.js?6327:33 Warning: Can't call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in DashboardCanvasItem (created by DashboardEditor)
    in div (created by DashboardEditor)
    in Resizable (created by GridItem)
    in DraggableCore (created by GridItem)
    in GridItem (created by ReactGridLayout)
    in div (created by ReactGridLayout)
    in ReactGridLayout (created by DashboardEditor)
    in div (created by DashboardEditor)
    in div (created by DashboardEditor)
    in div (created by DashboardEditor)
    in DashboardEditor (created by Dashboard)
    in div (created by Dashboard)
    in NavigationPrompt (created by withRouter(NavigationPrompt))
    in withRouter(NavigationPrompt) (created by Dashboard)

kardan

Looks good to me now

tangrammer · 2018-09-17T11:04:52Z

backend/src/akvo/lumen/config.clj

@@ -10,6 +10,7 @@
  (assert (:lumen-keycloak-client-secret env)
          (error-msg "LUMEN_KEYCLOAK_CLIENT_SECRET"))
  (assert (:lumen-keycloak-url env) (error-msg "LUMEN_KEYCLOAK_URL"))
+  #_(assert (:exporter-api-url env) (error-msg "EXPORTER_API_URL"))


maybe we can remove definitely this line

…shboards-#952 * develop: (37 commits) Hovering over charts shows different colour in shared visuals and dashboards #1667 #1673 fixed pivot table data caching bug when switch vis type Fix harcoded url in dev environment (#1688) Bar chart Show label toggle turned on for existing bars #1685 Bar chart value labels do not fit in the bar #1682 #1673 fixed linting Change visualisation type #1673 Add Show labels toggle for bar charts #1655 Changing dataset on existing chart crashes app #1679 bar labels toggle fixes 4 #1655 bar labels toggle fixes 3 #1655 Improve derive/parse-row-object-references impl and test coverage Align translations Support to row names with hyphens in update dataset #1655 bar labels toggle fixes Pie chart label not shown #1558 Add Show labels toggle for bar charts #1655 Add transactional support to update dataset Dataset initial view has a right blank empty rectangle #1658 #1573 added missing translations #1573 removed unused dep ... # Conflicts: # client/src/components/charts/PivotTable.jsx # client/src/components/charts/SimpleBarChart.jsx # client/src/components/visualisation/VisualisationPreview.jsx # client/src/containers/Visualisation.jsx # client/src/translations/en.json # client/src/translations/fr.json

finnfiddle added 4 commits July 18, 2018 17:38

Download option for visualisations and dashboards #952 WIP

4cdf6f6

An option to print a visualisation/dashboard #1095

106e172

Download option for visualisations and dashboards #952

f302ec4

#952 fixed linting

c461b93

finnfiddle self-assigned this Aug 1, 2018

finnfiddle requested review from kardan, iperdomo and dlebrero August 1, 2018 12:22

finnfiddle and others added 4 commits August 1, 2018 15:32

#952 export small fixes

09db74a

Fix backend env vars

2c3e2a7

Merge pull request #1587 from akvo/download-config-vars

7bf0531

Adapt backend env vars

kardan reviewed Aug 1, 2018

View reviewed changes

finnfiddle and others added 4 commits August 1, 2018 16:28

#952 save dashboard when add text

3d14cb5

#952 french export translations

bc54419

Add dev env var

0b74dbe

dlebrero reviewed Aug 1, 2018

View reviewed changes

finnfiddle and others added 12 commits August 2, 2018 12:56

#952 fixed exporter docker image version

fd8f875

[#952] Temporary disable cypress test

db543ec

[#952] Enabled first Cypress tests

34237a3

[#952] Upgrade Cypress and quiet install output

caf7b0e

[#952] Silent cypress npm install

07caf4f

Merge branch 'Download-option-for-visualisations-and-dashboards-#952'…

b2486b9

… of github.com:akvo/akvo-lumen into Download-option-for-visualisations-and-dashboards-#952 * 'Download-option-for-visualisations-and-dashboards-#952' of github.com:akvo/akvo-lumen: Add `dev` env var

[#952] Temp check docker-compose

72a05c0

Merge branches 'Download-option-for-visualisations-and-dashboards-#952'…

f9a7042

… and 'Download-option-for-visualisations-and-dashboards-#952' of github.com:akvo/akvo-lumen into Download-option-for-visualisations-and-dashboards-#952

[#952] Peek at docker compose

9dc6af4

[#952] Remove temp commands

5973cf1

[#952] Format changes

53da3aa

finnfiddle added 2 commits August 14, 2018 15:26

#952 create new incognito browser context each request in exporter

b479064

#952 cleanup exporter context after each export

fc6a190

kardan and others added 12 commits August 22, 2018 11:27

[#953] WIP proxy export request via backend

d24faa8

[#952] WIP exporter without refresh tokens

22ae0d4

First cut on not initialising a Keycloak session using token & refresh token but using the given token.

[#952] Fix doctoring issue and refactor exporter url

3263211

[#952] Using correct locale for exports

27aed1c

[#952] Remove old code

9ac2a81

[#952] Use generic exports endpoint

7c82f80

[#952] Dashboards use the export endpoint

af8305e

[#952] Use auth.js for tokens

66760a2

[#952] First steps on deploying exporter

6fdf194

[#952] Removed unused imports

202b9b0

Merge branch 'develop' into Download-option-for-visualisations-and-da…

abc2a69

…shboards-#952

kardan requested a review from tangrammer September 17, 2018 07:59

kardan approved these changes Sep 17, 2018

View reviewed changes

#952 fixed setstate error

c3c6b41

tangrammer reviewed Sep 17, 2018

View reviewed changes

kardan and others added 3 commits September 18, 2018 08:18

[#952] Remove commented code per review

03520c5

[#952] Use puppeteer clip option if available

4013b9b

kardan changed the title ~~Download option for visualisations and dashboards #952~~ Download option for visualisations and dashboards (connect #952) Oct 9, 2018

#952 fixed vis preview size props

b1e70a6

ghost added the in progress label Oct 9, 2018

kardan merged commit e4cc859 into develop Oct 9, 2018

ghost removed the in progress label Oct 9, 2018

tangrammer deleted the Download-option-for-visualisations-and-dashboards-#952 branch December 20, 2018 10:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download option for visualisations and dashboards (connect #952) #1586

Download option for visualisations and dashboards (connect #952) #1586

finnfiddle commented Aug 1, 2018

kardan left a comment

kardan Aug 1, 2018

kardan Aug 1, 2018

dlebrero Aug 1, 2018

kardan Aug 2, 2018

dlebrero Aug 2, 2018

finnfiddle Aug 2, 2018 •

edited

Loading

kardan commented Aug 16, 2018

kardan commented Aug 16, 2018

kardan commented Sep 17, 2018

kardan left a comment

tangrammer Sep 17, 2018

Download option for visualisations and dashboards (connect #952) #1586

Download option for visualisations and dashboards (connect #952) #1586

Conversation

finnfiddle commented Aug 1, 2018

kardan left a comment

Choose a reason for hiding this comment

kardan Aug 1, 2018

Choose a reason for hiding this comment

kardan Aug 1, 2018

Choose a reason for hiding this comment

dlebrero Aug 1, 2018

Choose a reason for hiding this comment

kardan Aug 2, 2018

Choose a reason for hiding this comment

dlebrero Aug 2, 2018

Choose a reason for hiding this comment

finnfiddle Aug 2, 2018 • edited Loading

Choose a reason for hiding this comment

kardan commented Aug 16, 2018

kardan commented Aug 16, 2018

kardan commented Sep 17, 2018

kardan left a comment

Choose a reason for hiding this comment

tangrammer Sep 17, 2018

Choose a reason for hiding this comment

finnfiddle Aug 2, 2018 •

edited

Loading