Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to parent results framework not propagated to children correctly #2951

Closed
punchagan opened this issue Nov 8, 2017 · 1 comment · Fixed by #2960
Closed

Updates to parent results framework not propagated to children correctly #2951

punchagan opened this issue Nov 8, 2017 · 1 comment · Fixed by #2960
Assignees
@punchagan
Labels
Bug Type: Results framework
Milestone
3.34.1 Brasilia h...

Comments

@punchagan
Copy link
Contributor

Creating a new period/indicator on a parent results framework doesn't create the children periods/indicators correctly, though the code intends to do so. This either needs to be fixed, or the code removed to avoid breaking things.
@punchagan punchagan added this to the 3.34 Brasilia milestone Nov 8, 2017
@punchagan punchagan self-assigned this Nov 8, 2017
punchagan added a commit that referenced this issue Nov 8, 2017
@punchagan
[#2951] Fix creation of child periods when a new parent is created
369d9bd
punchagan added a commit that referenced this issue Nov 8, 2017
@punchagan
[#2951] Fix creation of child indicators when a new parent is created
8d41cb2
punchagan added a commit that referenced this issue Nov 8, 2017
@punchagan
[#2951] Fix creation of child indicators when a new parent is created
cc20e4b
punchagan added a commit that referenced this issue Nov 9, 2017
@punchagan
[#2951] Data fix script for UTZ
de9a47a 
The bug in #2951 caused some corrupted data to be stored in a UTZ project. This
script essentially cleans up the mess, and recreates the data correctly. This
script, though, seems to run needlessly slowly. There might be scope for some
optimization in the child/parent detection code.
@punchagan punchagan mentioned this issue Nov 9, 2017
Merged
5 tasks
@punchagan
Copy link
Contributor Author

Closed in #2952

punchagan added a commit that referenced this issue Nov 9, 2017
@punchagan
[#2951] Data fix script for UTZ
9b5ab99 
The bug in #2951 caused some corrupted data to be stored in a UTZ project. This
script essentially cleans up the mess, and recreates the data correctly. This
script, though, seems to run needlessly slowly. There might be scope for some
optimization in the child/parent detection code.
zzgvh added a commit that referenced this issue Nov 9, 2017
@zzgvh
Merge pull request #2953 from akvo/issue/2951-fix-change-propagation-…
a3a849c 
…imported-results-framework

[#2951] Data fix script for UTZ
Code reviewed
punchagan added a commit that referenced this issue Nov 9, 2017
@punchagan
[#2951] Add target value as '0' when creating UTZ periods
004d0dd
punchagan added a commit that referenced this issue Nov 10, 2017
@punchagan
[#2951] Disallow multiple result/indicator/period children per project
b095e66 
When the results framework is imported from a project to it's children, each
child project should have only one child per result/indicator/period, and no
more.  This commit enforces this constraint in the DB.
punchagan added a commit that referenced this issue Nov 10, 2017
@punchagan
[#2951] Disallow multiple result/indicator/period children per project
267691e 
When the results framework is imported from a project to it's children, each
child project should have only one child per result/indicator/period, and no
more.  This commit enforces this constraint in the DB.
punchagan added a commit that referenced this issue Nov 10, 2017
@punchagan
[#2951] Disallow multiple result/indicator/period children per project
f4c21a6 
When the results framework is imported from a project to it's children, each
child project should have only one child per result/indicator/period, and no
more.  This commit enforces this constraint in the DB.
punchagan added a commit that referenced this issue Nov 10, 2017
@punchagan
[#2951] Disallow multiple result/indicator/period children per project
d45c2f6 
When the results framework is imported from a project to it's children, each
child project should have only one child per result/indicator/period, and no
more.  This commit enforces this constraint in the DB.
punchagan added a commit that referenced this issue Nov 15, 2017
@punchagan
[#2951] Hack to work around a bug in DRF
64c876b 
unique_together constraint seems to make the fields that are a part of it
hidden, even when they are marked as read_only. This commit adds a work around,
to fix this bug. Using the patch from
encode/django-rest-framework#4192 didn't seem to work.
There are other changes, possibly, that cause this code to not work in the
version of DRF we are using.
punchagan added a commit that referenced this issue Nov 16, 2017
@punchagan
[#2951] Disallow multiple result/indicator/period children per project
dbfd956 
When the results framework is imported from a project to it's children, each
child project should have only one child per result/indicator/period, and no
more.  This commit enforces this constraint in the DB.
punchagan added a commit that referenced this issue Nov 16, 2017
@punchagan
[#2951] Hack to work around a bug in DRF
547cebb 
unique_together constraint seems to make the fields that are a part of it
hidden, even when they are marked as read_only. This commit adds a work around,
to fix this bug. Using the patch from
encode/django-rest-framework#4192 didn't seem to work.
There are other changes, possibly, that cause this code to not work in the
version of DRF we are using.
@punchagan punchagan mentioned this issue Nov 16, 2017
Merged
5 tasks
zzgvh added a commit that referenced this issue Nov 16, 2017
@zzgvh
Merge pull request #2960 from akvo/issue/2951-disallow-multiple-resul…
f6cd29a 
…ts-framework-children

[#2951] Disallow multiple result/indicator/period children per project
Code reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punchagan punchagan

Labels
Bug Type: Results framework
Projects
RSR
Archived in project
Milestone
3.34.1 Brasilia hot-fix
Development

Successfully merging a pull request may close this issue.

[#2951] Disallow multiple result/indicator/period children per project akvo/akvo-rsr
2 participants
@zzgvh @punchagan