Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google maps API requests should use an API key #3368

Closed
punchagan opened this issue Sep 11, 2018 · 1 comment
Closed

Google maps API requests should use an API key #3368

punchagan opened this issue Sep 11, 2018 · 1 comment
Assignees
@punchagan
Labels
Bug
Milestone
Hot-fix 3.39.2 Be...

Comments

@punchagan
Copy link
Contributor

For development purposes only watermark is being shown on our maps as Google has made it mandatory to use an API key to talk to the maps API.
@punchagan punchagan self-assigned this Sep 11, 2018
punchagan added a commit that referenced this issue Sep 11, 2018
@punchagan
[#3368] Use an API key with all maps requests
29cca1f 
Closes #3368
@punchagan punchagan mentioned this issue Sep 11, 2018
Merged
5 tasks
punchagan added a commit that referenced this issue Sep 13, 2018
@punchagan
[#3368] Use an API key with all maps requests
d010c86 
Closes #3368
punchagan added a commit that referenced this issue Sep 13, 2018
@punchagan
[#3368] Use an API key with all maps requests
4530881 
Closes #3368
zzgvh added a commit that referenced this issue Sep 13, 2018
@zzgvh
Merge pull request #3369 from akvo/issue/3368-update-maps-api
7db8de1 
[#3368] Use an API key with all maps requests
@punchagan punchagan added this to the Hot-fix 3.39.2 Belmopan milestone Sep 13, 2018
@punchagan punchagan added the Bug label Sep 13, 2018
@punchagan
Copy link
Contributor Author

Closed in #3369

punchagan added a commit that referenced this issue Nov 5, 2018
@punchagan
[#3368] Fix missing gmaps_api_key in inclusion_tags templates
e09f319 
The extra_context is added only to template rendering for views. When rendering
the templates for inclusion_tags, the extra variables defined using
`extra_context` don't get passed. This causes the map URLs in the projects map
widget to show a warning about missing Google Maps API key.

This commit fixed the problem, that was assumed to have been fixed with
4530881.
zzgvh added a commit that referenced this issue Nov 7, 2018
@zzgvh
Merge pull request #3407 from akvo/issue/3368-inclusion-tags-gmaps-ap…
2aa0770 
…i-key

[#3368] Fix missing gmaps_api_key in inclusion_tags templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punchagan punchagan

Labels
Bug
Projects
RSR
Archived in project
Milestone
Hot-fix 3.39.2 Belmopan
Development

No branches or pull requests
1 participant
@punchagan