Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update button behaviour whilst logged in #407

Closed
rumca opened this issue Nov 29, 2013 · 10 comments
Closed

Add Update button behaviour whilst logged in #407

rumca opened this issue Nov 29, 2013 · 10 comments
Assignees
Milestone

Comments

@rumca
Copy link
Contributor

rumca commented Nov 29, 2013

Not sure if this is the issue that users were reporting where they were unable to add updates to their projects.

When you are not signed into RSR and are viewing the "Latest updates" page (where all of the updates are listed) there is an option to add an update if you sign in:

partnersiteupdateloggedin

However for signed in users, this add update option is not available from this page. Instead users only have the option of adding from the project overview page:

partnersiteupdatemissing

@ghost ghost assigned adriancollier Nov 29, 2013
@adriancollier
Copy link
Contributor

I cannot replicate this issue - I always see an Add Update button even if I don't have the rights to add an update:
screen shot 2014-03-17 at 12 14 25

@adriancollier
Copy link
Contributor

@rumca do you still see this behaviour?

@adriancollier adriancollier assigned rumca and unassigned adriancollier Mar 24, 2014
@rumca
Copy link
Contributor Author

rumca commented Mar 24, 2014

@adriancollier just tested on UAT and the issue seems to have been resolved at some point - I'll close this

@rumca rumca closed this as completed Mar 24, 2014
@adriancollier adriancollier removed this from the 2.3.5 Uglyfruit milestone Mar 25, 2014
@rumca
Copy link
Contributor Author

rumca commented Jul 2, 2014

@adriancollier I've just re-encountered this issue on UAT partnersites. When a user isn't logged in:

updatescreennotsignedin

Then when they are logged in:

updatescreensignedin

Not sure if we need to address it or not

@rumca rumca reopened this Jul 2, 2014
@KasperBrandt KasperBrandt added this to the 2.3.10 Zambo milestone Jul 3, 2014
@KasperBrandt KasperBrandt assigned KasperBrandt and unassigned rumca Jul 3, 2014
@zzgvh
Copy link
Contributor

zzgvh commented Jul 3, 2014

After some testing I think the problem is that the Add update button is not shown when you're logged in on the updates listing page. On both the project main page and the single update page it's shown correctly when either 1) the user isn't logged in, or 2) is logged in and allowed to create an update.

@KasperBrandt
Copy link
Contributor

@zzgvh Incorporated your suggestions, can you check again?

zzgvh added a commit that referenced this issue Jul 29, 2014
[#407] Updated logic for 'Add update' button
@KasperBrandt
Copy link
Contributor

Merged in #683

@adriancollier
Copy link
Contributor

The current functionality seems to grey out the Add Update button when you are not logged in - I thought this should push the user to sign in...

@adriancollier adriancollier reopened this Aug 28, 2014
@rumca
Copy link
Contributor Author

rumca commented Aug 29, 2014

@adriancollier since this is the current functionality on core RSR should we close the issue? Perhaps we can open a new one for changing it to prompt the user to sign in

@adriancollier
Copy link
Contributor

Agree - I'll create a new issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants