Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/432 add show empty value for jmp chart #433

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Feature/432 add show empty value for jmp chart #433

merged 6 commits into from
Oct 13, 2023

Conversation

wayangalihpratama
Copy link
Collaborator

@wayangalihpratama wayangalihpratama commented Oct 12, 2023 •
edited
Loading

TODO / DONE

  • Add show empty value for JMP Charts #432
  • Enable show empty value feature on JMP chart
  • Filter JMP chart data by show empty value feature
  • Refine main chart (stacked chart) data when check/uncheck show empty value by setLoading status to true the render the filtered chart data

@wayangalihpratama wayangalihpratama changed the base branch from main to sandbox October 12, 2023 09:43
@coveralls
Copy link

coveralls commented Oct 12, 2023 •
edited
Loading

Coverage Status

coverage: 79.514%. remained the same when pulling f071858 on feature/432-add-show-empty-value-for-jmp-chart into a062969 on sandbox.

@wayangalihpratama wayangalihpratama marked this pull request as draft October 12, 2023 11:26
@wayangalihpratama wayangalihpratama marked this pull request as ready for review October 12, 2023 12:09
dedenbangkit
dedenbangkit requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@dedenbangkit dedenbangkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this

canvas

dedenbangkit
dedenbangkit requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@dedenbangkit dedenbangkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canvas

New issue

@dedenbangkit dedenbangkit merged commit 14f843e into sandbox Oct 13, 2023
3 checks passed
@dedenbangkit dedenbangkit deleted the feature/432-add-show-empty-value-for-jmp-chart branch October 13, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedenbangkit dedenbangkit dedenbangkit requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wayangalihpratama @coveralls @dedenbangkit