Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require boost 1.50 #29

Closed
wants to merge 3 commits into from

Conversation

andrewshadura
Copy link
Contributor

No description provided.

@andrewshadura
Copy link
Contributor Author

/usr/include/boost/thread/xtime.hpp:23:5: error: expected identifier before numeric constant.
This says it's fixed in 1.50

@florianjacob
Copy link
Member

Something we should concider: Debian Wheezy (next stable version) only seems to have boost version 1.49: http://packages.debian.org/wheezy/libboost-all-dev

@andrewshadura
Copy link
Contributor Author

It doesn't matter as 1.49 isn't usable anyway.

@TheMarex
Copy link
Contributor

As alacarte builds perfectly fine with boost 1.48 I'm really against merging this. If you can only exclude 1.49, maybe.

@andrewshadura
Copy link
Contributor Author

It doesn't build here, with the same error message as in a bug report above. A side note: I'm using g++ 4.8, maybe it has more complete C++11 support, which may be the cause.

Updated: it's newer glibc, not g++.

@andrewshadura
Copy link
Contributor Author

More information here: https://svn.boost.org/trac/boost/ticket/6940

@Scheirle
Copy link
Member

I have no problems building with:
Boost: 1.49.0
g++: 4.7.2

@andrewshadura
Copy link
Contributor Author

@Scheirle, your libc isn't recent enough.

@TheMarex: Well, an alternative solution would be to declare a complex dependency like (libc < 2.17 && boost >= 1.47) || (libc >= 2.17 && boost >= 1.50), but I'm not sure CMake is expressive enough to allow that. Could you please try doing so?

@TheMarex
Copy link
Contributor

Should be fixed with commit ad98588
@andrewshadoura Could you please verify if this detects the issue?

@andrewshadura
Copy link
Contributor Author

I think it probably should. If the syntax correct — which I presume is — it should work.
Thanks.

@TheMarex TheMarex closed this Apr 26, 2013
TheMarex added a commit that referenced this pull request Apr 28, 2013
Fix CMake confuring on Windows after #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants