Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Icon Choice #967

Closed
4 tasks
jwilm opened this issue Dec 24, 2017 · 9 comments · Fixed by #1451
Closed
4 tasks

Finalize Icon Choice #967

jwilm opened this issue Dec 24, 2017 · 9 comments · Fixed by #1451

Comments

@jwilm
Copy link
Contributor

jwilm commented Dec 24, 2017

We settled on using the icon from @net. In #863, some changes were discussed including using the blue flame variant, and tweaking the stroke to make it show up better on dark backgrounds.

Tasks

  • @net to tweak border
  • @net to provide final SVG
  • Ship icon for macOS
  • Ship icon for Linux
@MarcelRobitaille
Copy link

Any updates on this?

@chrisduerr
Copy link
Member

chrisduerr commented Feb 5, 2018

I think we're still waiting on @net to make the requested changes and provide the final SVG.

As far as I know he did not provide any licensing information and there also is no SVG we could work with. So unless we can get a hold of him we'd probably need to design something new.

@jedahan
Copy link
Contributor

jedahan commented Feb 5, 2018

I'd love as an easter egg, to be able to keep the current variant as well, but yknow, there are definitely higher priorities.

@chrisduerr
Copy link
Member

If @net is not available for providing the icon we chose, we might have to look for a new icon?

Maybe open up a RFC or something like this? I doubt that this issue will progress anytime soon.

@chrisduerr
Copy link
Member

chrisduerr commented Jun 14, 2018

With permission of @net I've tried to reproduce the icon he's designed as an SVG (since the original was not an SVG).

Here are the results I was able to achieve:

Scanlines + Background:
Scanlines + Background

Background:
Background

Without Background:
No Background

Since I'm far from artistically capable I'm sure there are a few tweaks left to be done to make these perfect, however they should get us going and make it easy for others to have a point of reference to work with.

I've tried to incorporate the feedback about the border color directly, hopefully that's a bit better?

EDIT: It should be noted that it's hard to get a good look at the scanlines with the size this image shows up in on github. So that probably should be taken into account.

chrisduerr added a commit to chrisduerr/alacritty that referenced this issue Jul 19, 2018
This adds the SVG files for the three different versions of the
Alacritty logo to the repository. The three variations are the logo with
scanlines, without scanlines and without background or scanlines.

To unclutter the root directory of the repository a bit, every file
which is just copied to the system during the build process has been
moved into the `extra` directory. This should clean things up a bit and
allowed renaming the completions a bit to make them comply with the
default naming scheme for completions for each shell by default.

This fixes alacritty#967.
chrisduerr added a commit to chrisduerr/alacritty that referenced this issue Jul 19, 2018
This adds the SVG files for the three different versions of the
Alacritty logo to the repository. The three variations are the logo with
scanlines, without scanlines and without background or scanlines.

To unclutter the root directory of the repository a bit, every file
which is just copied to the system during the build process has been
moved into the `extra` directory. This should clean things up a bit and
allowed renaming the completions a bit to make them comply with the
default naming scheme for completions for each shell by default.

This fixes alacritty#967.
@liamdawson
Copy link

liamdawson commented Oct 29, 2018

Any progress on this? I'd love to replace the generic X11 icon I get on Linux when alt-tabbing to Alacritty (#1591).

@zacps
Copy link
Contributor

zacps commented Oct 29, 2018

Just commenting here to make note that the icon Alacritty uses on windows is assets/windows/alacritty.ico and MUST be a .ico file, so whatever gets chosen should be converted.

chrisduerr added a commit to chrisduerr/alacritty that referenced this issue Mar 31, 2019
This adds the SVG files for the three different versions of the
Alacritty logo to the repository. The three variations are the logo with
scanlines, without scanlines and without background or scanlines.

To unclutter the root directory of the repository a bit, every file
which is just copied to the system during the build process has been
moved into the `extra` directory. This should clean things up a bit and
allowed renaming the completions a bit to make them comply with the
default naming scheme for completions for each shell by default.

This fixes alacritty#967.
chrisduerr added a commit to chrisduerr/alacritty that referenced this issue Mar 31, 2019
This adds the SVG files for the three different versions of the
Alacritty logo to the repository. The three variations are the logo with
scanlines, without scanlines and without background or scanlines.

To unclutter the root directory of the repository a bit, every file
which is just copied to the system during the build process has been
moved into the `extra` directory. This should clean things up a bit and
allowed renaming the completions a bit to make them comply with the
default naming scheme for completions for each shell by default.

This fixes alacritty#967.
@musm
Copy link

musm commented Apr 11, 2019

How come my icon does not look anything like the ones posted here
image

in fact it seems to be wrong in terms of the pixel size (blurry, probably due to scaling issue)

@chrisduerr
Copy link
Member

The white background should be fixed with the latest master. There are some scaling issues with Windows but that seems to be because of issues with the .ico format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

7 participants