Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase font size in CSD decorations on Wayland #4454

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

kchibisov
Copy link
Member

@kchibisov kchibisov commented Nov 21, 2020

Winit changed the default font size for CSD from 17pt to 11pt, so
restoring it, since it's way too small.

Fixes #4443.

Winit changed the default font size for CSD from 17pt to 11pt, so
restoring it, since it's way too small.
@kchibisov
Copy link
Member Author

Just a reference on how it looks, it's also affected correctly by DPI scaling.

picture

Copy link
Member

@chrisduerr chrisduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the plans for winit? I'd like to see this happen in winit before Alacritty so I can consider if it's even worth adding a workaround to Alacritty.

Also by opening this PR I'd assume you want to include this into 0.6.0 preliminarily? I think I'm personally slightly against this and I'd rather release 0.6.0 as-is.

@kchibisov
Copy link
Member Author

Also by opening this PR I'd assume you want to include this into 0.6.0 preliminarily? I think I'm personally slightly against this and I'd rather release 0.6.0 as-is.

As it was already mentioned it was regressed from 17 to 11, and since it's 17 in sctk, it makes sense to restore it here, winit will be updated to 17 eventually.

@kchibisov
Copy link
Member Author

What are the plans for winit? I'd like to see this happen in winit before Alacritty so I can consider if it's even worth adding a workaround to Alacritty.

Added to winit rust-windowing/winit@165e51d

@chrisduerr chrisduerr merged commit da6f0a5 into alacritty:master Nov 22, 2020
@kchibisov kchibisov deleted the increase-font-size branch March 13, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Resize window title on title bar
2 participants