update Rspec

private_please.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'cattr_reader_preloaded'
 
   gem.add_development_dependency 'rake' # to run 'All specs' in Rubymine
-  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'rspec', '>=3.3'
   gem.add_development_dependency 'guard-rspec'
   gem.add_development_dependency 'rb-fsevent'
 end

spec/01_tracking_candidate_methods/load_utils_spec.rb

@@ -12,35 +12,35 @@ def gem?(requiree)
 
 
   example '.standard_lib? detects if a string matches a standard library' do
-    std_lib?('csv'                ).should be_true
-    std_lib?('csv.rb'             ).should be_true
-    std_lib?('bigdecimal'         ).should be_true
-    std_lib?('bigdecimal/util'    ).should be_true
-    std_lib?('bigdecimal/util.rb' ).should be_true
-
-    std_lib?('rspec'              ).should be_false
-    std_lib?('private_please'     ).should be_false
-    std_lib?('/an/abs/path/csv'   ).should be_false
-    std_lib?('../csv'             ).should be_false
-    std_lib?('lib/../csv'         ).should be_false
+    std_lib?('csv'                ).should be_truthy
+    std_lib?('csv.rb'             ).should be_truthy
+    std_lib?('bigdecimal'         ).should be_truthy
+    std_lib?('bigdecimal/util'    ).should be_truthy
+    std_lib?('bigdecimal/util.rb' ).should be_truthy
+
+    std_lib?('rspec'              ).should be_falsey
+    std_lib?('private_please'     ).should be_falsey
+    std_lib?('/an/abs/path/csv'   ).should be_falsey
+    std_lib?('../csv'             ).should be_falsey
+    std_lib?('lib/../csv'         ).should be_falsey
   end
 
   example '.gem? detects if a string matches a gem' do
-    gem?('csv'                ).should be_false
-    gem?('csv.rb'             ).should be_false
-    gem?('bigdecimal'         ).should be_false
-    gem?('bigdecimal/util'    ).should be_false
-    gem?('bigdecimal/util.rb' ).should be_false
-
-    gem?('rspec'              ).should be_true
-    gem?('rspec/core/rake_task').should be_true
-    gem?('rspec/autorun'      ).should be_true
-    gem?('coderay'            ).should be_true
-    gem?('lib/../rspec'       ).should be_true  # same as gem?('rspec')
-
-    gem?('/an/abs/path/rspec' ).should be_false
-    gem?('../rspec'           ).should be_false
-    gem?('rspec/../lib/foo'   ).should be_false
+    gem?('csv'                ).should be_falsey
+    gem?('csv.rb'             ).should be_falsey
+    gem?('bigdecimal'         ).should be_falsey
+    gem?('bigdecimal/util'    ).should be_falsey
+    gem?('bigdecimal/util.rb' ).should be_falsey
+
+    gem?('rspec'              ).should be_truthy
+    gem?('rspec/core/rake_task').should be_truthy
+    gem?('rspec/autorun'      ).should be_truthy
+    gem?('coderay'            ).should be_truthy
+    gem?('lib/../rspec'       ).should be_truthy  # same as gem?('rspec')
+
+    gem?('/an/abs/path/rspec' ).should be_falsey
+    gem?('../rspec'           ).should be_falsey
+    gem?('rspec/../lib/foo'   ).should be_falsey
   end
 
 end

spec/06_at_exit_spec.rb

@@ -4,15 +4,13 @@
 
   it 'prints the PP simpletext report to $stdout (when not in test mode)' do
     $private_please_tests_are_running = false
-    PrivatePlease::Reporter::SimpleText.stub(:new => stub(:text => '<the-report-text>'))
-    $stdout.
-        should_receive(:puts).
-        with('<the-report-text>')
+    allow(PrivatePlease::Reporter::SimpleText).to receive_messages(new: double(text: '<the-report-text>'))
+    expect($stdout).to receive(:puts).with('<the-report-text>')
     begin
       PrivatePlease.at_exit
     ensure
       $private_please_tests_are_running = true
     end
   end
 
-end
+end

spec/spec_helper.rb

@@ -12,7 +12,7 @@ def self.reset_before_new_test
 end
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.expect_with(:rspec) { |c| c.syntax = [:expect, :should] }
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 

spec/units/candidates_store_spec.rb

@@ -22,15 +22,15 @@
   example 'storing the 1st instance method candidate stores it so that it can be retrieved' do
     candidates_store.store(object_to_s)
 
-    candidates_store.stored?(object_to_s).should be_true
+    candidates_store.stored?(object_to_s).should be_truthy
     candidates_store.instance_methods.should == {'Object' => mnames_for('to_s')}
     candidates_store.class_methods   .should be_empty
   end
 
   example 'storing the 1st class method candidate stores it so that it can be retrieved' do
     candidates_store.store(object_new)
 
-    candidates_store.stored?(object_new).should be_true
+    candidates_store.stored?(object_new).should be_truthy
     candidates_store.instance_methods.should be_empty
     candidates_store.class_methods   .should == {'Object' => mnames_for('new')}
   end
@@ -39,7 +39,7 @@
     candidates_store.store(object_to_s)
     candidates_store.store(object_hash)
 
-    candidates_store.stored?(object_hash).should be_true
+    candidates_store.stored?(object_hash).should be_truthy
     candidates_store.instance_methods.should == {'Object' => mnames_for(%w(hash to_s))}
     candidates_store.class_methods   .should be_empty
   end