Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort and pre-commit config #437

Merged
merged 8 commits into from
Oct 14, 2021
Merged

Add isort and pre-commit config #437

merged 8 commits into from
Oct 14, 2021

Conversation

jack89roberts
Copy link
Contributor

@jack89roberts jack89roberts commented Oct 13, 2021

@jack89roberts
Copy link
Contributor Author

Are you happy to use this @nbarlowATI ? Hadn't come across it before but spotted Angus using it in bpl-next and seems handy (sorts all imports alphabetically in sensible groups).

Also added a pre-commit config, again haven't done that before but means isort, black, flake8 run locally with every commit if you use it.

@nbarlowATI
Copy link
Member

Good idea! I definitely like the idea of the automagic pre-commit stuff too!

@nbarlowATI nbarlowATI merged commit 7828f47 into develop Oct 14, 2021
@jack89roberts jack89roberts deleted the feature/pre-commit branch August 26, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants