Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code ingress with git #611
Code ingress with git #611
Changes from 64 commits
fc6e91f
3c0aecd
6056af1
8b8d20c
2ab0fce
424bbd3
3f04679
ff48810
8507b63
7c8d377
9a52480
b9d5788
f8c415a
ccdc93f
fd62e1f
f139b2f
69df12d
49df919
23a2733
59d3073
ab9de4c
0881963
b5b2337
53485ba
22f8c4b
b511029
bddd44d
e3b99ac
d995c47
c831b0e
46b778d
56cd9ca
bbb965b
a3c0323
f7dfccc
3550638
e4d16e2
bfe7147
f5eb496
2e45544
f9b685a
c6c2ca7
9efc447
a15a703
3bc913c
2906264
6182e04
bdd6f65
59761df
d76ab25
0fd1356
e4a3304
c639e47
5bd6752
d70ed67
fdef7f2
aebd59a
8525dbd
9af6278
8c8b8c5
f4c0a9e
162e611
dfd1dc9
837b2da
a4ca583
16573fc
7e9ab18
1fc2bac
74fd45b
5c1026b
aa05a61
3efe4bc
1c927b8
6738f75
c8619c7
1b703e5
7275923
77884e8
f6ec3fa
9416fba
db81a4d
ebbe624
36e464d
9406ce2
1b5248b
3f68aae
b6cafdd
6619fc7
4d91a42
2f25476
cead499
a878316
63e8401
18f37db
6b67674
60a7ab6
4e733d5
1b5f85f
4a01cd4
de0c669
fd72517
c2b01c0
ef3ac43
cf1c8e6
ad02e44
ae42dc7
e6716ed
a2bc238
0f512c7
edbcc1f
cde38a9
5811409
4514a98
274c93b
4416003
c147ba7
be37161
2dab934
c82dfab
90064ac
c77453d
5c858fb
435b33a
b96fc4e
9fa64be
4c3dbca
7fc3f86
17ce3b6
44b74ee
7acd3e5
14a0b9d
66964e0
978db16
3be6504
a845ba7
71774f8
32a4de5
ccab24d
f8ee363
67baafa
cae41f3
7b844c3
815f2f0
e832a0b
86bba46
0018a69
243980d
59b5d08
6d36d72
a80cb82
48d2be3
2f505d2
8041233
a77afc9
b7ca0da
8d477fc
6173b11
bb6ca85
cc4977b
2ab4d54
678be5b
6e7d2a1
3462ba6
53f8e63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider renaming these throughout (since we neither of them are external in the current model). Maybe GITLAB-REVIEW and GITLAB-USER or something like that? I'm sure @nbarlowATI can think of good names :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - shall we go with GITLAB-REVIEW and GITLAB-USER?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly even just
GITLAB
for the internal one? We could then domain-join the machine and expose it (instead of by IP address) ashttp://gitlab-sre-sandbox.<domain>
or justhttp://gitlab-sandbox.<domain>
if you remove the-SRE-
part of the name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do these names work with the netbios name limit of 15 characters?
gitlab-review-sre-sandbox
feels too long.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed:
GITLAB-INTERNAL
->GITLAB
GITLAB-EXTERNAL
->GITLAB-REVIEW
Is this likely to be an issue? I can't find that particular string anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May not arise here if the VMs are not domain joined. I think we mainly (only?) see this in the name used for the Active Directory Computer account for a domain joined VM, which seems to use the Netbios name of the VM, which is limited to 15 characters. @jemrobinson AM I recalling the issue correctly? I know we had an issue with this with the compute VM names early on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider making these domain joined in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just pointing out that there are restrictions on Netbios name lengths for domain joined VMs so names need to be unique in first 15 characters. Not sure if domain joining is a benefit here. I think we can add DNS records to allow name / FQDN based access and the LDAP search user is enough to support LDAP login. I quite like that research users are not users on these VMs. Happy to hear the pros of domain joining though.