Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Models Action and Front End showing Action findings #687

Merged
merged 55 commits into from
Jun 19, 2024
Merged

Check Models Action and Front End showing Action findings #687

merged 55 commits into from
Jun 19, 2024

Conversation

Tonks684
Copy link
Contributor

@Tonks684 Tonks684 commented Apr 4, 2024

No description provided.

@Tonks684
Check Models Action
5cfbfdb
@Tonks684
test for nod20 actions
28bf4c7
@Tonks684
toml updates
b3c7ff3
@Tonks684
entry point
bc17e02
@Tonks684
entry point
ccc8e5f
@Tonks684
entry point
0281ba9
@Tonks684
allow install true
b4f2e9b
@Tonks684
debuging check model outputs when unable to install package via pip
e77463d
@Tonks684
debuging check model outputs when unable to install package via pip
836e5df
@Tonks684
debuging check model outputs when unable to install package via pip
c146567
@Tonks684
subprocess.check_call shell=True
4a989c6
@Tonks684
model catalog checks
7ecf898
@Tonks684
model catalog checks
f600641
@Tonks684
model catalog checks
dda6ca4
@Tonks684
model catalog checks requests
467efe8
@Tonks684
model catalog action
cdfd746
@Tonks684
model catalog action
edf9034
@Tonks684
check_models
d96eecc
@Tonks684
url updates
453d43b
@Tonks684
url update VEdge
f53c8d3
@Tonks684
print config
815333f
@Tonks684
Update path to use os.path.join
10a1767
@Tonks684
model load successfully check
b65d676
@Tonks684
flake8 updates
5364367
@Tonks684
flak8 updates
eedc864
@Tonks684
flake8 updates
b61e283
@Tonks684 Tonks684 self-assigned this Apr 4, 2024
@Tonks684 Tonks684 requested a review from IFenton April 4, 2024 14:02
IFenton
IFenton approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@IFenton IFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good (though I'm not able to test it locally at the moment, loading some of the models on my mac causes python to crash at the moment)

.github/workflows/check-models.yml Outdated Show resolved Hide resolved
src/scivision/catalog/check_models.py Outdated Show resolved Hide resolved
src/scivision/catalog/check_models.py Show resolved Hide resolved
src/scivision/catalog/check_models.py Show resolved Hide resolved
@Tonks684
Copy link
Contributor Author

Ready for your review

IFenton
IFenton reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@IFenton IFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but apart from that this is looking good.

.github/workflows/check-models.yml Outdated Show resolved Hide resolved
.github/workflows/check-models.yml Outdated Show resolved Hide resolved
frontend/src/ModelTable.jsx Outdated Show resolved Hide resolved
@Tonks684
Copy link
Contributor Author

Does this need anything else?

@IFenton
Copy link
Contributor

IFenton commented Jun 19, 2024

LGTM

@IFenton IFenton merged commit 5db4116 into alan-turing-institute:main Jun 19, 2024
9 checks passed
@IFenton IFenton mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IFenton IFenton IFenton approved these changes

Assignees

@Tonks684 Tonks684

Labels
None yet
Projects
No open projects
Scivision fortnightly planning: 2024-04-16 to 2024-04-30
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tonks684 @IFenton