fix: fix deprecated light constants and change to kelvin #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. No worries; I don't have any lights and I merged PRs in blind before. I'd appreciate if you checked in on the repo after we release it to see if there's anything obvious to fix, but no worries either way. |
alandtse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not fully tested this
I coded the changes below. Then when I went to test them, I found that the 1 of the lights that used to connect via Alexa was dead and I am unable to find where I put the other one (embarrassing). I don't normally use lights via Alexa, I just had them from some previous iterations of things I was working on.
So .... if people would like to test and report back, I can try to refine as needed. However, @alandtse, I'd totally understand if you just want to remove/close this PR since it is untested. Sorry.
This PR fixes the deprecated constants, but also changes to use kelvin behind the scenes since that is what the light entities now use and there isn't an easy way to replace the deprecated constants and keep using mireds.