-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option for CORS headers to support cluster proxy setup #7
Conversation
Cluster proxy setup required correct CORS headers to move notes to whiteboard. This patch adds an option to configure it
I'm surprised Etherpad does not have a built-in solution for this... |
I did not find something builtin in etherpad. See https://github.com/ether/etherpad-lite/blob/develop/src/node/hooks/express/importexport.js#L45 And I chose to use a seperate config file because |
I usually wait for @alangecker to check on this but I'm not sure about his availability right now. So I'm merging this one and maybe we can re-discuss about transfering the Etherpad libs to the BBB account. |
@pedrobmarin I'm currently rather limited in what I can contribute to BBB, I would therefore be happy if we could move these libs to the BBB account! 🙂 If I try to transfer it by myself, I get following error:
If someone (@ffdixon? 🙂) could provide me with that permission temporarily I could transfer them over |
Hi @alangecker, I've created https://github.com/bigbluebutton/bbb-etherpad-plugin and made you a maintainer. Don't hesitate to reach out if you need anything more. |
Hey guys, I would like to know the status here, this was already merged, but is it already applied in BBB? I am asking this in order to proceed with the tests and review of this PR: bigbluebutton/bigbluebutton#15457 and also, to close this other one: bigbluebutton/bigbluebutton#15753. |
Hi @GuiLeme I built BBB 2.6 beta 1 packages from source and this patch is included. IMHO bigbluebutton/bigbluebutton#15753 can be closed and bigbluebutton/bigbluebutton#15457 can be merged :-) |
Cluster proxy setup required correct CORS headers to move notes to whiteboard. This patch adds an option to configure it. To configure it add a file
/etc/bigbluebutton/etherpad.json
with similar content:related to bigbluebutton/bigbluebutton#15457
related to bigbluebutton/bigbluebutton#15753