Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX props can be elements too #267

Closed
arv opened this issue Jun 18, 2018 · 0 comments
Closed

JSX props can be elements too #267

arv opened this issue Jun 18, 2018 · 0 comments

Comments

@arv
Copy link
Contributor

arv commented Jun 18, 2018

The following fails:

const x = <a b=<c/> d="e"/>;

https://sucrase.io/#compareWithTypeScript=true&code=%0Aconst%20x%20%3D%20%3Ca%20b%3D%3Cc%2F%3E%20d%3D%22e%22%2F%3E%3B

See JSXAttributeValue at https://facebook.github.io/jsx/
arv added a commit to arv/sucrase that referenced this issue Jun 20, 2018
@arv
JSX props values can be elements too
f9437fe 
Fixes alangpierce#267

The value of a JSX attribute/prop can be a JSX element or a fragment.

See JSXAttributeValue at https://facebook.github.io/jsx/
@arv arv mentioned this issue Jun 20, 2018
Merged
alangpierce pushed a commit that referenced this issue Jun 21, 2018
@arv @alangpierce
JSX props values can be elements too (#268)
6c3e80f 
Fixes #267

The value of a JSX attribute/prop can be a JSX element or a fragment.

Also fix a stray comma in JSX fragment output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arv