JSX props values can be elements too #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes alangpierce#267 The value of a JSX attribute/prop can be a JSX element or a fragment. See JSXAttributeValue at https://facebook.github.io/jsx/
There was an extra stray comma.
|
Let me know if you would prefer 2 PRs instead of 2 commits. They are independent except for the test. |
|
Thank you! Looks good to me! (For larger things, 2 PRs would be nice, but here it's fine to combine them.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
The value of a JSX attribute/prop can be a JSX element or a fragment.
See JSXAttributeValue at https://facebook.github.io/jsx/