Fix parsing of methods and fields named "declare" #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #545 When originally porting babel/babel#11146, there was a mistake where we were using `eatContextual` when actually it was important to use `tsParseModifier`, since `tsParseModifier` won't eat a name token if the following token indicates that it must be the name of a method or field. This PR fixes that by switching to `tsParseModifier` as Babel does. It might be good to later refactor/simplify `tsParseModifier` if the keyword specificity is just for error handling (and to maybe avoid the snapshot/restore), but that can be a follow-up.
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 55 55
Lines 5806 5806
Branches 1313 1313
=======================================
Hits 4758 4758
Misses 764 764
Partials 284 284
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545
When originally porting babel/babel#11146, there was a
mistake where we were using
eatContextualwhen actually it was important touse
tsParseModifier, sincetsParseModifierwon't eat a name token if thefollowing token indicates that it must be the name of a method or field. This PR
fixes that by switching to
tsParseModifieras Babel does.It might be good to later refactor/simplify
tsParseModifierif the keywordspecificity is just for error handling (and to maybe avoid the
snapshot/restore), but that can be a follow-up.