Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to link the thumbnail to Google Photos? #39

Closed
kmaustral opened this issue Jan 4, 2024 · 5 comments
Closed

Is it possible to link the thumbnail to Google Photos? #39

kmaustral opened this issue Jan 4, 2024 · 5 comments

Comments

@kmaustral
Copy link

kmaustral commented Jan 4, 2024

Thank you for the plugin. It adds a lot of value to my daily reviews.

I had assumed that you could click on a thumbnail and open the full photo in Google Photos.

I am using this markdown
[![]({{local_thumbnail_link}})]({{google_photo_url})

Can this work in code blocks? If not, would it be possible to link the displayed images to the date in Google Photos?

@alangrainger
Copy link
Owner

You do click on the thumbnail and it opens the full photo in Google Photos - that's exactly how the plugin currently works.

It's plain Markdown, so it will work like any normal image link works in Obsidian. Therefore it won't work in codeblocks, because codeblocks in Obsidian don't display images.

Can you explain a bit more what is the actual issue, as what you're describing as your desired behaviour is already exactly how it works.

@kmaustral
Copy link
Author

kmaustral commented Jan 7, 2024 via email

@alangrainger
Copy link
Owner

alangrainger commented Jan 7, 2024

There are a couple of issues with the Markdown you have in your comment:

  1. You're missing the second closing brace } after google_photo_url.
  2. You're missing the opening [ which will turn it into a link.

It should be:

[![](local_file.jpg)](https://remote_link)

The template will be:

[![]({{local_thumbnail_link}})]({{google_photo_url}}) 

@kmaustral
Copy link
Author

Many thanks for that. I've corrected the code and it works well now. I don't recall seeing it written like that in the Read Me. It may help to include it.

Your plugin is much appreciated.

@alangrainger
Copy link
Owner

Probably a good idea to add to the readme, but FYI it's the default text in the settings box. Just delete whatever custom value you added and you'll see this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants