Inherit trailing_slash attribute from parent router #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #115
When
trailing_slash
is not explicitly given on a NestedRouter interface, we copy thetrailing_slash
attribute from the parent.There is some care taken to avoid just passing a True or False into the parent constructer, because it limits the ability to inherit all possible values. (Plus it avoids the need to do a roundabout truthiness inspection on the parent's
trailing_slash
, because the external interface is boolean instead of the internal storage which is a string.)Had to write a little helper for the tests because URLs change across Django versions. I think I caught all the cases that matter. (It passes tox tests for all django versions using py36, which is all i ran).