[core] Tweak ratelimiting a little better for low rates #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix another issue with a ratelimit of 1 byte/second. Hopefully no-one was actually trying to use a limit this low. Additionally, simplify this logic now. Rate limits are much easier than they used to be as the engine works in bytes, not 'blocks' or 'chunks'. Back in the day there had to be estimates made for the amount of data which would be received for a given 'ReceiveAsync' call. Now we're just counting the raw number of bytes sent/received, or read/written, so we don't need complicated math to account for over/under-shoot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix another issue with a ratelimit of 1 byte/second. Hopefully no-one was actually trying to use a limit this low.
Additionally, simplify this logic now. Rate limits are much easier than they used to be as the engine works in bytes, not 'blocks' or 'chunks'.
Back in the day there had to be estimates made for the amount of data which would be received for a given 'ReceiveAsync' call. Now we're just counting the raw number of bytes sent/received, or read/written, so we don't need complicated math to account for over/under-shoot.