Skip to content

Commit

Permalink
(2019-10-01, 0ab715e) amp-action-macro: 1
Browse files Browse the repository at this point in the history
Previous history on prod-config.json:

- 0ab715e - 2019-10-01T10:32:36-04:00 - Launch,<amp-action-macro>,(ampproject#24810)
  • Loading branch information
alanorozco committed Dec 7, 2020
1 parent 969e0c0 commit 917f1c0
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 16 deletions.
1 change: 0 additions & 1 deletion build-system/global-configs/canary-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"canary": 1,
"a4aProfilingRate": 0.01,
"adsense-ad-size-optimization": 0.1,
"amp-action-macro": 1,
"amp-ad-ff-adx-ady": 0.01,
"amp-auto-ads-adsense-holdout": 0.1,
"ampdoc-fie": 1,
Expand Down
1 change: 0 additions & 1 deletion build-system/global-configs/prod-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"a4aProfilingRate": 0.01,
"adsense-ad-size-optimization": 0.1,
"amp-accordion-display-locking": 1,
"amp-action-macro": 1,
"amp-ad-ff-adx-ady": 0.01,
"amp-auto-ads-adsense-holdout": 0.1,
"ampdoc-fie": 1,
Expand Down
4 changes: 2 additions & 2 deletions extensions/amp-action-macro/0.1/amp-action-macro.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/
import {LayoutPriority} from '../../../src/layout';
import {Services} from '../../../src/services';
import {isExperimentOn} from '../../../src/experiments';
import {userAssert} from '../../../src/log';

/** @const {string} */
Expand All @@ -39,7 +38,8 @@ export class AmpActionMacro extends AMP.BaseElement {
/** @override */
buildCallback() {
userAssert(
isExperimentOn(this.win, 'amp-action-macro'),
/* experiment: amp-action-macro */
true,
'Experiment is off'
);
const {element} = this;
Expand Down
6 changes: 0 additions & 6 deletions extensions/amp-action-macro/0.1/test/test-amp-action-macro.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {ActionInvocation} from '../../../../src/service/action-impl';
import {ActionTrust} from '../../../../src/action-constants';
import {AmpActionMacro} from '../amp-action-macro';
import {Services} from '../../../../src/services';
import {toggleExperiment} from '../../../../src/experiments';

describes.realWin(
'amp-action-macro',
Expand All @@ -35,8 +34,6 @@ describes.realWin(
beforeEach(() => {
win = env.win;
doc = win.document;

toggleExperiment(win, 'amp-action-macro', true);
});

function newActionMacro() {
Expand All @@ -60,7 +57,6 @@ describes.realWin(

it('should not build if experiment is off', () => {
return allowConsoleError(() => {
toggleExperiment(env.win, 'amp-action-macro', false);
return newActionMacro().catch((err) => {
expect(err.message).to.include('Experiment is off');
});
Expand All @@ -75,8 +71,6 @@ describes.realWin(
let unreferrableMacro;
let unreferrableMacroElement;
beforeEach(() => {
toggleExperiment(win, 'amp-action-macro', true);

// This macro is referrable and can be invoked by the macro element(s)
// defined after it.
referrableMacroElement = doc.createElement('amp-action-macro');
Expand Down
6 changes: 0 additions & 6 deletions tools/experiments/experiments-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,6 @@ export const EXPERIMENTS = [
spec: 'https://github.com/ampproject/amphtml/issues/6106',
cleanupIssue: 'https://github.com/ampproject/amphtml/pull/6351',
},
{
id: 'amp-action-macro',
name: 'AMP extension for defining action macros',
spec: 'https://github.com/ampproject/amphtml/issues/19494',
cleanupIssue: 'https://github.com/ampproject/amphtml/pull/19495',
},
{
id: 'ios-fixed-no-transfer',
name: 'Remove fixed transfer from iOS 12.2 and up',
Expand Down

0 comments on commit 917f1c0

Please sign in to comment.