Skip to content

Commit

Permalink
(2017-05-16, ca20059) pump-early-frame: 1
Browse files Browse the repository at this point in the history
Previous history on prod-config.json:

- ca20059 - 2017-05-16T09:31:30-04:00 - Start Doubleclick Fast Fetch potential SRA delay measure experiment (ampproject#9298)
  • Loading branch information
alanorozco committed Dec 7, 2020
1 parent 7da7cef commit 948776b
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 14 deletions.
1 change: 0 additions & 1 deletion build-system/global-configs/canary-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"flexAdSlots": 0.05,
"intersect-resources": 0,
"ios-fixed-no-transfer": 1,
"pump-early-frame": 1,
"remove-task-timeout": 0,
"swg-gpay-api": 1,
"swg-gpay-native": 1,
Expand Down
1 change: 0 additions & 1 deletion build-system/global-configs/prod-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"flexAdSlots": 0.05,
"intersect-resources": 0,
"ios-fixed-no-transfer": 0,
"pump-early-frame": 1,
"swg-gpay-api": 1,
"swg-gpay-native": 1,
"amp-ad-no-center-css": 0,
Expand Down
2 changes: 1 addition & 1 deletion src/runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ function maybeLoadCorrectVersion(win, fnOrStruct) {
* pumped.
*/
function maybePumpEarlyFrame(win, cb) {
if (!isExperimentOn(win, 'pump-early-frame')) {
if (!(/* isExperimentOn(win, 'pump-early-frame') // launched: true */ true)) {
cb();
return;
}
Expand Down
4 changes: 0 additions & 4 deletions test/unit/test-runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import {installPlatformService} from '../../src/service/platform-impl';
import {installTimerService} from '../../src/service/timer-impl';
import {setShadowDomSupportedVersionForTesting} from '../../src/web-components';
import {toArray} from '../../src/types';
import {toggleExperiment} from '../../src/experiments';
import {vsyncForTesting} from '../../src/service/vsync-impl';

describes.fakeWin(
Expand Down Expand Up @@ -202,7 +201,6 @@ describes.fakeWin(
);

it('should not maybePumpEarlyFrame when body not yet present', () => {
toggleExperiment(win, 'pump-early-frame', true);
// Make document.body be null on first invocation to simulate
// JS executing before the rest of the doc has been parsed.
const {body} = win.document;
Expand All @@ -223,14 +221,12 @@ describes.fakeWin(
'should not maybePumpEarlyFrame ' +
'when a renderDelayingExtension is present',
() => {
toggleExperiment(win, 'pump-early-frame', true);
win.document.body.appendChild(document.createElement('amp-experiment'));
extensionRegistrationTest();
}
);

it('should maybePumpEarlyFrame and delay extension execution', () => {
toggleExperiment(win, 'pump-early-frame', true);
let progress = '';
const queueExtensions = win.AMP;
const highPriority = regularExtension((amp) => {
Expand Down
7 changes: 0 additions & 7 deletions tools/experiments/experiments-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,6 @@ export const EXPERIMENTS = [
spec: 'https://github.com/ampproject/amphtml/issues/22220',
cleanupIssue: 'https://github.com/ampproject/amphtml/issues/22220',
},
{
id: 'pump-early-frame',
name:
'If applicable, let the browser paint the current frame before ' +
'executing the callback.',
cleanupIssue: 'https://github.com/ampproject/amphtml/issues/8237',
},
{
id: 'web-worker',
name: 'Web worker for background processing',
Expand Down

0 comments on commit 948776b

Please sign in to comment.