Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in guide page for 'Creating a dynamic view with ejs' #101

Closed
twgardner2 opened this issue May 10, 2018 · 3 comments
Closed

Error in guide page for 'Creating a dynamic view with ejs' #101

twgardner2 opened this issue May 10, 2018 · 3 comments

Comments

@twgardner2
Copy link

I apologize if this is the wrong place to bring this up, but I think there is a small error in the perk guide. The final example on the 'Creating a dynamic view with ejs' page, shows the escaped ejs tag where I think it should show the unescaped ejs tag:
perk error

@alarner
Copy link
Owner

alarner commented May 10, 2018

Hey @twgardner2 thanks for the bug report. I've got this on my todo list now, but might not fix for a few weeks because I've got a ton of other work. If you want to submit a PR this is where you can find that doc page: https://github.com/alarner/perk-docs/blob/master/src/v1/guides/creating-a-dynamic-view-with-ejs.md

Cheers!

@twgardner2
Copy link
Author

twgardner2 commented May 10, 2018 via email

@alarner
Copy link
Owner

alarner commented May 20, 2018

@twgardner2 merged and deployed! Thanks for the PR.

@alarner alarner closed this as completed May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants