Warns the user on providing multiple arguments for <projectName> #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albe-rosado
requested changes
May 12, 2019
There was a problem hiding this comment.
Thank you, so much for your time, I totally agree, can you instead of using the chalk library, use the ansiColors defined in the utils module? I didn't want to include another library just for the sake of printing colors in the terminal, trying to keep the projects with as few deps as possible. Again, thank you.
jamesgeorge007
changed the title
albe-rosado
requested changes
May 12, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Currently,
create-proton-app <arg1> <arg2>works fine without any sort of warnings that doesn't make any sense.