Merge pull request #144 from albe/undefined-matcher

Fix matcher with undefined property checks
albe · Feb 9, 2021 · d9c28c0 · d9c28c0
2 parents bb2ab76 + 4c88c01
commit d9c28c0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/util.js b/src/util.js
@@ -52,7 +52,7 @@ function matches(document, matcher) {
             if (!matches(document[prop], matcher[prop])) {
                 return false;
             }
-        } else if (document[prop] !== matcher[prop]) {
+        } else if (typeof matcher[prop] !== 'undefined' && document[prop] !== matcher[prop]) {
             return false;
         }
     }

diff --git a/test/Storage.spec.js b/test/Storage.spec.js
@@ -429,6 +429,19 @@ describe('Storage', function() {
             expect(index.length).to.be(1);
         });
 
+        it('indexes documents by property object matcher ignoring undefined properties', function(done) {
+            storage = createStorage();
+            storage.open();
+            storage.write({type: 'Bar', other: '1'});
+            storage.write({type: 'Foo', other: '2'});
+            storage.write({type: 'Baz', other: '3'}, () => {
+                let index = storage.ensureIndex('foo', {type: 'Foo', other: undefined});
+
+                expect(index.length).to.be(1);
+                done();
+            });
+        });
+
         it('reopens existing indexes', function() {
             storage = createStorage();
             storage.open();