Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matcher with undefined property checks #144

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

albe
Copy link
Owner

@albe albe commented Feb 9, 2021

Previously, an object matcher that contained an undefined property would not match documents that contained that property, but only during the run of the creation. Once the index was reopened, the matcher would work as expected, because the undefined matcher property was not serialized into the index.
This change fixes that by correctly ignoring matcher properties that are undefined (e.g. when deleting a property from an object).

@albe albe added bug P: Storage Affects the storage layer labels Feb 9, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 97.233% when pulling 4c88c01 on undefined-matcher into bb2ab76 on master.

@albe albe added this to In progress in 0.8 Feb 9, 2021
@albe albe merged commit d9c28c0 into master Feb 9, 2021
@albe albe deleted the undefined-matcher branch February 9, 2021 00:16
@albe albe moved this from In progress to Done in 0.8 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P: Storage Affects the storage layer
Projects
No open projects
0.8
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants