refactor(single_booking): replace recurringBookingId with referenced object
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3782460693
💛 - Coveralls |
albertms10
deleted the
refactor/replace-recurring-booking-id-with-referenced-object
branch
albertms10
commented
Dec 30, 2022
Comment on lines
+91
to
+93
| booking: (booking.recurringBooking != null | ||
| ? booking.recurringBooking! | ||
| : booking) |
There was a problem hiding this comment.
This change introduced an undesired behavior after popping a changed booking from the form dialog. It is addressed in #167.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the referenced object instead of its UUID as an indirect identifier, we can get rid of expensive
findByIdoperations.