Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(booking_preview_panel_action_bar): pass a copy of the booking object to BookingDialog #167

Merged

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Dec 30, 2022

After #163, when popping an already changed booking from the BookingDialog, changes persisted in the app’s state until it was refreshed—although no storage operation was run—due to changes done to the referenced Booking object.

@albertms10 albertms10 added the bug Something isn't working label Dec 30, 2022
@albertms10 albertms10 added this to the Version 0.8 milestone Dec 30, 2022
@albertms10 albertms10 self-assigned this Dec 30, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3808933346

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.787%

Totals Coverage Status
Change from base Build 3808794227: 0.0%
Covered Lines: 372
Relevant Lines: 1101

💛 - Coveralls

@albertms10 albertms10 merged commit 75090e2 into main Dec 30, 2022
@albertms10 albertms10 deleted the fix/pass-a-copy-of-the-booking-object-to-booking-dialog branch December 30, 2022 20:33
albertms10 added a commit that referenced this pull request Jan 15, 2023
…edit

Prevents from running the same issue as solved in #167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants