Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cabin): expose BookingCollection from constructor #178

Merged

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Jan 14, 2023

Taking advantage of the work in #175, this PR aims to expose the BookingCollection member from within the Cabin constructor.

@albertms10 albertms10 added refactor The code needs to be refactored test The code needs to implement tests labels Jan 14, 2023
@albertms10 albertms10 added this to the Version 0.8 milestone Jan 14, 2023
@albertms10 albertms10 self-assigned this Jan 14, 2023
@albertms10 albertms10 merged commit 9d4e53d into main Jan 14, 2023
@albertms10 albertms10 deleted the refactor/expose-booking-collection-from-cabin-constructor branch January 14, 2023 21:55
albertms10 added a commit that referenced this pull request Jan 15, 2023
albertms10 added a commit that referenced this pull request Jan 15, 2023
* refactor(booking_collection): rewrite serializable methods `fromJson` and `toJson`

Continues #175, #178

* refactor(cabin_collection): implement `SerializableList`

* test(model): remove unnecessary variable declaration

* test(booking_collection): add test cases for serializable methods

* test(booking_collection): fix test case description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant