refactor(cabin): remove redirection methods to BookingCollection
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3888271505
💛 - Coveralls |
albertms10
deleted the
refactor/remove-cabin-redirection-methods-to-booking-collection
branch
albertms10
added a commit
that referenced
this pull request
Jan 14, 2023
albertms10
added a commit
that referenced
this pull request
Jan 14, 2023
* refactor(cabin): expose `BookingCollection` from constructor Continues #175 * test(cabin): adapt use-cases
albertms10
added a commit
that referenced
this pull request
Jan 15, 2023
* refactor(booking_collection): rewrite serializable methods `fromJson` and `toJson` Continues #175, #178 * refactor(cabin_collection): implement `SerializableList` * test(model): remove unnecessary variable declaration * test(booking_collection): add test cases for serializable methods * test(booking_collection): fix test case description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce code complexity by publicly exposing the
Cabin.bookingCollectionmember and removing unnecessary redirection methods in theCabinclass, improving code maintainability and discoverability.