fix(scale_pattern): check for descendingIntervalSteps in == (#137)

albertms10 · May 20, 2023 · fbce358 · fbce358
1 parent 0dc24bd
commit fbce358
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/lib/src/scale/scale_pattern.dart b/lib/src/scale/scale_pattern.dart
@@ -280,7 +280,10 @@ final class ScalePattern {
   @override
   bool operator ==(Object other) =>
       other is ScalePattern &&
-      const ListEquality<Interval>().equals(intervalSteps, other.intervalSteps);
+      const ListEquality<Interval>()
+          .equals(intervalSteps, other.intervalSteps) &&
+      const ListEquality<Interval>()
+          .equals(_descendingIntervalSteps, other._descendingIntervalSteps);
 
   @override
   int get hashCode => Object.hashAll(intervalSteps);

diff --git a/test/src/scale/scale_pattern_test.dart b/test/src/scale/scale_pattern_test.dart
@@ -419,13 +419,35 @@ void main() {
           ScalePattern.ionian,
           ScalePattern.mixolydian,
           ScalePattern.wholeTone,
+          // Melodic minor scale (ascending only)
+          const ScalePattern([
+            Interval.majorSecond,
+            Interval.minorSecond,
+            Interval.majorSecond,
+            Interval.majorSecond,
+            Interval.majorSecond,
+            Interval.majorSecond,
+            Interval.minorSecond,
+          ]),
+          ScalePattern.melodicMinor,
         };
         collection.addAll(collection);
         expect(collection.toList(), const [
           ScalePattern.major,
           ScalePattern.aeolian,
           ScalePattern.mixolydian,
           ScalePattern.wholeTone,
+          // Melodic minor scale (ascending only)
+          ScalePattern([
+            Interval.majorSecond,
+            Interval.minorSecond,
+            Interval.majorSecond,
+            Interval.majorSecond,
+            Interval.majorSecond,
+            Interval.majorSecond,
+            Interval.minorSecond,
+          ]),
+          ScalePattern.melodicMinor,
         ]);
       });
     });