Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(enharmonic): rewrite based on semitones #11

Merged
merged 7 commits into from
Apr 7, 2023
Merged

refactor(enharmonic): rewrite based on semitones #11

merged 7 commits into from
Apr 7, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added refactor The code needs to be refactored test The code needs to implement tests labels Apr 6, 2023
@albertms10 albertms10 self-assigned this Apr 6, 2023
@albertms10 albertms10 marked this pull request as ready for review April 7, 2023 16:31
@coveralls
Copy link

coveralls commented Apr 7, 2023 •
edited

Pull Request Test Coverage Report for Build 4639725115

  • 12 of 39 (30.77%) changed or added relevant lines in 7 files are covered.
  • 24 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-8.6%) to 39.688%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/classes/enharmonic_interval.dart 6 7 85.71%
lib/src/classes/interval.dart 2 3 66.67%
lib/src/classes/tonality.dart 0 6 0.0%
lib/src/note/note.dart 0 8 0.0%
lib/src/classes/enharmonic_note.dart 1 12 8.33%
Files with Coverage Reduction New Missed Lines %
lib/src/classes/tonality.dart 1 0%
lib/src/enums/notes.dart 4 47.06%
lib/src/note/note.dart 5 16.67%
lib/src/classes/enharmonic_note.dart 14 2.94%
Totals Coverage Status
Change from base Build 4623949621: -8.6%
Covered Lines: 127
Relevant Lines: 320
💛 - Coveralls

@albertms10 albertms10 merged commit 69678ef into main Apr 7, 2023
@albertms10 albertms10 deleted the refactor/rewrite-enharmonic-based-on-semitones branch April 7, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls