Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(enharmonic): rewrite based on semitones #11

Merged
merged 7 commits into from
Apr 7, 2023
Merged

refactor(enharmonic): rewrite based on semitones #11

merged 7 commits into from
Apr 7, 2023

Commits on Apr 6, 2023

  1. refactor: use firstWhereOrNull instead of orElse

    @albertms10
    albertms10 committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    d6fc782 View commit details
    Browse the repository at this point in the history

  2. refactor(enharmonic): rewrite based on semitones

    @albertms10
    albertms10 committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7427314 View commit details
    Browse the repository at this point in the history

  3. refactor(note): simplify enharmonic methods

    @albertms10
    albertms10 committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    a2cebc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. refactor(enharmonic): assert semitones in range

    @albertms10
    albertms10 committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    715786b View commit details
    Browse the repository at this point in the history

  2. feat(enharmonic_note): add static const constructors

    @albertms10
    albertms10 committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    86a4182 View commit details
    Browse the repository at this point in the history

  3. refactor(tonality): rewrite using EnharmonicNote.transposeBy method

    @albertms10
    albertms10 committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    1ada113 View commit details
    Browse the repository at this point in the history

  4. feat(enharmonic): implement items getter

    @albertms10
    albertms10 committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    6cf9ecd View commit details
    Browse the repository at this point in the history