refactor: PositionedNote composition with Note instead of inheritance #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4974174985
💛 - Coveralls |
albertms10
approved these changes
May 13, 2023
I'm totally fine with renaming it to
I prefer to keep pull requests as straightforward and concise as possible, so I would do it in a separate PR. Please note that I created a PR for this some days ago: #99 (comment). Thanks! |
plammens
force-pushed
the
refactor/positioned-note-composition
branch
from
ee996d0
to
e58af6d
Compare
albertms10
reviewed
May 27, 2023
| @@ -136,15 +138,14 @@ final class PositionedNote extends Note { | |||
|
|
|||
| @override | |||
| bool operator ==(Object other) => | |||
| super == other && other is PositionedNote && octave == other.octave; | |||
| other is PositionedNote && note == other.note && octave == other.octave; | |||
|
|
|||
| @override | |||
| int get hashCode => Object.hash(super.hashCode, octave); | |||
There was a problem hiding this comment.
This deprecated hashCode was left behind, as no exhaustive tests existed to catch a bad implementation there.
Fixed in #155.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
Comments:
semitonesdoesn't collide withNote.semitones, I renamedsemitonesFromRootHeighttosemitonesto conform withMusicItem, but perhaps you prefer keeping the more explicit name and adding an aliassemitones => semitonesFromRootHeight?Transposable<T>definition change in this PR now that it is easier, or in a separate one?