Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(positioned_note): use correct hashCode values #155

Merged
merged 2 commits into from May 27, 2023
Merged

fix(positioned_note): use correct hashCode values #155

merged 2 commits into from May 27, 2023

Conversation

albertms10
Copy link
Owner

Closes #106

@albertms10 albertms10 added bug Something isn't working test The code needs to implement tests labels May 27, 2023
@albertms10 albertms10 added this to the Road to 0.9 milestone May 27, 2023
@albertms10 albertms10 self-assigned this May 27, 2023
@albertms10 albertms10 marked this pull request as ready for review May 27, 2023 23:10
@coveralls
Copy link

coveralls commented May 27, 2023 •
edited

Pull Request Test Coverage Report for Build 5101307454

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5094788467: 0.0%
Covered Lines: 598
Relevant Lines: 598
💛 - Coveralls

@albertms10 albertms10 mentioned this pull request May 27, 2023
Merged
@albertms10 albertms10 merged commit 334bcde into main May 27, 2023
3 checks passed
@albertms10 albertms10 deleted the fix/use-correct-positioned-note-hash-code branch May 27, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
bug Something isn't working test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.9
Development

Successfully merging this pull request may close these issues.

Rewrite inheritance with composition for the PositionedNote class
2 participants
@albertms10 @coveralls