Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 refactor(interval)!: rewrite IntervalSizeExtension methods as private #227

Merged
merged 3 commits into from
Jul 24, 2023
Merged

💥 refactor(interval)!: rewrite IntervalSizeExtension methods as private #227

merged 3 commits into from
Jul 24, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Jul 24, 2023 •
edited
Loading

Public API

  • IntervalSizeExtension.fromSemitones() has been moved to Interval.sizeFromSemitones() while keeping the same API.

Private API

In favor of a consistent API, these IntervalSizeExtension methods on int (now _IntervalSize) have been declared as private.

  • IntervalSizeExtension.semitones has been moved to _IntervalSize._semitones
  • IntervalSizeExtension.isPerfect has been moved to _IntervalSize._isPerfect
  • IntervalSizeExtension.isCompound has been moved to _IntervalSize._isCompound
  • IntervalSizeExtension.simplified has been moved to _IntervalSize._simplified

Thus, the new way to use them is through the methods defined on Interval (see #222, #223, #224, #225).

@albertms10 albertms10 added refactor The code needs to be refactored test The code needs to implement tests labels Jul 24, 2023
@albertms10 albertms10 added this to the Road to 0.11 milestone Jul 24, 2023
@albertms10 albertms10 self-assigned this Jul 24, 2023
@coveralls
Copy link

coveralls commented Jul 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5646990913

  • 33 of 33 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5646927333: 0.0%
Covered Lines: 807
Relevant Lines: 807
💛 - Coveralls

@albertms10 albertms10 requested a review from plammens July 24, 2023 15:47
@albertms10 albertms10 merged commit c1898d9 into main Jul 24, 2023
2 checks passed
@albertms10 albertms10 deleted the refactor!/rewrite-interval-size-extension-as-private branch July 24, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plammens plammens Awaiting requested review from plammens

Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@albertms10 @coveralls