Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tonality): ✨ add isTheoretical getter #377

Merged
merged 2 commits into from Jan 20, 2024
Merged

feat(tonality): ✨ add isTheoretical getter #377

merged 2 commits into from Jan 20, 2024

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added documentation Improvements or additions to documentation enhancement New feature or request test The code needs to implement tests labels Jan 20, 2024
@albertms10 albertms10 added this to the Road to 0.16.0 milestone Jan 20, 2024
@albertms10 albertms10 self-assigned this Jan 20, 2024
@albertms10 albertms10 force-pushed the feat/add-tonality-is-theoretical-getter branch from 818368b to acf4c9d Compare January 20, 2024 22:29
@coveralls
Copy link

coveralls commented Jan 20, 2024 •
edited

Pull Request Test Coverage Report for Build 7597223779

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7597108261: 0.0%
Covered Lines: 1065
Relevant Lines: 1065
💛 - Coveralls

@albertms10 albertms10 force-pushed the feat/add-tonality-is-theoretical-getter branch from acf4c9d to c76bbcb Compare January 20, 2024 22:30
@albertms10
refactor(tonality): ♻️ assert distance is not null
510362c 
All tonalities have a canonical `keySignature`, so there’s no need to prevent it from being `null`.
@albertms10 albertms10 merged commit 6eef394 into main Jan 20, 2024
2 checks passed
@albertms10 albertms10 deleted the feat/add-tonality-is-theoretical-getter branch January 20, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
documentation Improvements or additions to documentation enhancement New feature or request test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.16
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls