Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tonality): ✨ add isTheoretical getter #377

Merged
merged 2 commits into from
Jan 20, 2024
Merged

feat(tonality): ✨ add isTheoretical getter #377

merged 2 commits into from
Jan 20, 2024

Commits on Jan 20, 2024

  1. feat(tonality): ✨ add isTheoretical getter

    @albertms10
    albertms10 committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    c76bbcb View commit details
    Browse the repository at this point in the history

  2. refactor(tonality): ♻️ assert distance is not null 

    All tonalities have a canonical `keySignature`, so there’s no need to prevent it from being `null`.
    @albertms10
    albertms10 committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    510362c View commit details
    Browse the repository at this point in the history