Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(accidental): rewrite new Accidental class #8

Merged
merged 4 commits into from Apr 5, 2023
Merged

refactor(accidental): rewrite new Accidental class #8

merged 4 commits into from Apr 5, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added the enhancement New feature or request label Apr 5, 2023
@albertms10 albertms10 self-assigned this Apr 5, 2023
@coveralls
Copy link

coveralls commented Apr 5, 2023 •
edited

Coverage Status

Coverage: 48.338% (+1.7%) from 46.687% when pulling b4732eb on refactor/rewrite-new-accidental-class into 86067fb on main.

@albertms10 albertms10 merged commit 202f0b2 into main Apr 5, 2023
2 checks passed
@albertms10 albertms10 deleted the refactor/rewrite-new-accidental-class branch April 5, 2023 23:18
albertms10 added a commit that referenced this pull request Apr 5, 2023
@albertms10
docs: reference new Accidental class instead of enum
0d05d01 
Continues #8
@albertms10 albertms10 mentioned this pull request Apr 5, 2023
Merged
@albertms10 albertms10 added refactor The code needs to be refactored and removed enhancement New feature or request labels Apr 5, 2023
albertms10 added a commit that referenced this pull request Apr 5, 2023
@albertms10
docs: reference new Accidental class instead of enum (#9)
149187d 
Continues #8
@albertms10 albertms10 added the test The code needs to implement tests label Apr 5, 2023
@albertms10 albertms10 mentioned this pull request Apr 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls