Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attention loss #7

Closed
affromero opened this issue Jul 31, 2018 · 1 comment
Closed

Attention loss #7

affromero opened this issue Jul 31, 2018 · 1 comment

Comments

@affromero
Copy link

affromero commented Jul 31, 2018

Hi,

You mentioned L2 loss for Eq 2, but there is L1 in the code (https://github.com/albertpumarola/GANimation/blob/master/models/ganimation.py#L244-L245). Is this ok?

@albertpumarola
Copy link
Owner

Hi,
Yes, just doing the mean is working better for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants