use bindata and package assets

[djcas9]

So, this is what I would do so that no external deps are needed outside of the import. This will solve the GOPATH issues and also remove external files making a single binary build easy.

[djcas9]

@albrow Let me know your thoughts on this. This would just require rebuilding the bindata.go fille when any lua scripts or changed, added or removed. go-bindata scripts/... in the root dir. (https://github.com/jteeuwen/go-bindata)

[albrow]

@mephux, thank for looking into this and acting so quickly. I was actually just checking out binddata and it looks pretty cool! As it turns out, I simultaneously worked on my own solution and created PR #11. I'm going to take a little bit of time to look over both solutions and figure out which will work best, and I'd love to hear your feedback on #11 too.

At first glance, it appears that the binddata solution adds a little more complexity and overhead. Correct me if I'm wrong, but I believe Zoom would still need to read the lua "files" from the binddata library at runtime and then parse them with a call to redis.NewScript.

In comparison, #11 just pulls the content out of the lua files and passes them as strings into redis.NewScript. I personally find the generated code easier to understand (even if the code that generates it at scripts/main.go is a little messy for now).

I would appreciate it if you head over to #11 and verify that it does work for you, i.e. that the tests still pass with your setup. In the meantime, I will be verifying that the tests pass for my setup with #10.

[albrow]

Also please note for next time... as described in the contributing section of the README, I would prefer that pull requests are merged into develop, not master. This helps me manage the branching model and version numbers in a sane way.

I think I'm going to move the instructions into a Contributing.md file to make it easier for people to find.

[djcas9]

@albrow no problem. So the bindata is loaded into memory. So, if I import your lib into my CLI application it just loads that into memory and reads from that. So, it's pretty much the same as reading it in as a string. The plus side of bindata is not having to ship the scripts folder with my binary or program.

[albrow]

@mephux okay I see. I've looked at the output at bindata.go and run go-bindata scripts/... myself. As expected, tests still pass for my setup (a pretty standard single GOPATH and no dependency manager). Also passes if you run from any directory, which is good.

There's still a tad more overhead in terms of function calls, converting things from bytes, etc. But I think performance-wise it's negligible. I'm more concerned about the complexity in terms of understanding the code. The thing to consider now is whether I want to import a third-party library or just use the code I wrote. They both have the same effect and the same features. Pros and cons to each. I just need a moment to think about it.

[djcas9]

@albrow yea, you're solution looks fine - going to close this.

[albrow]

Okay. Thanks for bringing this issue up! It's now fixed in version 0.9.3 on master. Please don't hesitate to create more PRs or issues in the future :)