Fix script path problems by go generating scripts ahead of time #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems were occurring when people were using godep or multiple go paths. The new technique is to use the build package to locate the directory where Zoom lives and then find the scripts relative to that.
…of finding script files altogether.
albrow
added a commit
that referenced
this pull request
May 13, 2015
Fix script path problems by go generating scripts ahead of time
|
This change is now included in version 0.9.3 on master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executable at scripts/main.go converts all the script files into static strings and writes the result to scripts.go. For users of the zoom library, scripts.go will just work. The onus is on me to remember to run go generate every time I change the scripts.
This will work with all types of configurations (godep, multiple GOPATHS, etc.) and is safe for bundling into binaries.
Just waiting for feedback to make sure this works for everyone before I merge it.