Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency to opencv-contrib-python and opencv-contrib-python-headless #707

Closed
tastelessjolt opened this issue Sep 15, 2020 · 2 comments

Comments

@tastelessjolt
Copy link

馃悰 Add dependency to opencv-contrib-python and opencv-contrib-python-headless

Not exactly a bug. If other parts of the code use extra modules provided by the contrib module, but also want to use albumentations.

To Reproduce

Steps to reproduce the behavior:

  1. Install albumentations in an environment where cv2 is provided by opencv-contrib-python or opencv-contrib-python-headless

Expected behavior

Can take the opencv-contrib-python or opencv-contrib-python-headless as dependencies while installing

Environment

  • Albumentations version (e.g., 0.1.8): 0.4.6
  • Python version (e.g., 3.7): 3.7
  • OS (e.g., Linux): Linux
  • How you installed albumentations (conda, pip, source): pip
  • Any other relevant information:

Additional context

Reference for what these packages provide: https://github.com/skvark/opencv-python#installation-and-usage

Maybe you can add these entries in here.

CHOOSE_INSTALL_REQUIRES = [("opencv-python>=4.1.1", "opencv-python-headless>=4.1.1")]

@agchang-cgl
Copy link
Contributor

+1, this makes it a pain to use in a production system that needs the opencv-contrib-* dependency.

@Dipet
Copy link
Collaborator

Dipet commented Feb 5, 2021

Fixed in #837

@Dipet Dipet closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants