Allow opencv-contrib-* to satisfy opencv requirement
#837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… satisfy the opencv requirement. `opencv-contrib-*` is a superset of the `opencv-python-*` API, so this allows dependents to use the contrib variant along with albumentations.
agchang-cgl
force-pushed
the
opencv-contrib-support
branch
from
9f8ea9d
to
8858711
Compare
Dipet
approved these changes
Feb 5, 2021
creafz
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opencv-contrib-*is a superset of theopencv-python-*API, so this allows dependents to use the contrib variants along with albumentations [1] (see point #3).I'm working on a project which uses albumentations, but also needs to use
opencv-contrib-python-headless. Since albumentations doesn't recognize that as satisfyingopencv(as an abstract dependency), it installs theopencv-python-headlessversion, which causes thecv2namespace to be clobbered and no longer recognize modules in contrib.Note, the
imgaugdependency also forces an install ofopencv-python[2] (the non-headless version :(), but this can be worked around with:[1] aleju/imgaug#473
[2] https://pypi.org/project/opencv-contrib-python-headless/