Add getNftSales() #190
Add getNftSales() #190
Conversation
…s endpoint response
…NftSales endpoint
…k-js into nft-api-get-nft-sales
src/api/nft-namespace.ts
Outdated
| * @param options - The optional parameters to use for the request. | ||
| * @beta | ||
| */ | ||
| getNftSales(options?: GetNftSales): Promise<GetNftSalesResponse>; |
There was a problem hiding this comment.
Rename GetNftSales to GetNftSalesOptions
| * | ||
| * @public | ||
| */ | ||
| export enum SortingOrder { |
There was a problem hiding this comment.
Can we reuse the AssetTransfersOrder and just re-export it?
ex: export { AssetTransfersOrder as SortingOrder }
There was a problem hiding this comment.
Yup, I think it would be a good idea to refactor it later to have one enum representing the supported sorting orders by the API. I didn't do it in this pr to avoid a breaking change with the AssetTransfersOrder
test/unit/nft-api.test.ts
Outdated
| mock.onGet().reply(400, 'fromBlock should be a non-negative integer'); | ||
|
|
||
| await expect( | ||
| alchemy.nft.summarizeNftAttributes(contractAddress) |
There was a problem hiding this comment.
typo: replace with getNftSales()
There was a problem hiding this comment.
It seems that I have been swayed by the dark powers of the copy paste 🤣
| return NftTakerType.BUYER; | ||
| case 'SELLER': | ||
| return NftTakerType.SELLER; | ||
| default: |
There was a problem hiding this comment.
Remove the UNKNOWN enum since the taker is always guaranteed to be one or the other. Can you throw an error if for some reason we can't parse the enum?
Changelog
getNftSalesmethod in thenftnamespace.GetNftSalesResponseandNftSaletypes to describe the result of thegetNftSalesendpoint.getNftSalesmethod.Extra
Filtering by the
takerfield doesn't seem to work correctly, when setting the param to eitherbuyerorsellerthe results from the API don't change and results with the incorrecttakervalue are returned.Filtering by
taker=sellerFiltering by
taker=buyerAlso, the docs mention that the
fromBlockandtoBlockparams should accept hex integers as valid values but when setting them as such, the API returns an error so the type in the SDK has been implemented to allow only the types that are working correctly.