Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test static properties #52

Merged
merged 1 commit into from
Sep 29, 2023
Merged

chore: test static properties #52

merged 1 commit into from
Sep 29, 2023

Conversation

MarkJPerry
Copy link
Contributor

Describe your changes

Add tests for currencies

D&D Beyond character link

N/A

Pre-review checklist

  • I have added a description of my changes
  • I have formatted my code with yarn format
  • I have added a link to a D&D Beyond character that can be used to test these changes
  • I have read the contributing guidelines
  • I agree to the code of conduct

@MarkJPerry MarkJPerry changed the title chore: test currencies chore: test static properties Sep 29, 2023
voidrender
voidrender requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@voidrender voidrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small typos to fix up and then these are good to go! It is so nice to have this test coverage, so thank you for taking the time to go through these scenarios.

test/convert.descriptors.test.ts Outdated Show resolved Hide resolved
test/convert.currencies.test.ts Outdated Show resolved Hide resolved
@MarkJPerry
chore: test static features
8e3837b 
- currencies
- descriptors
- exp
- raceName
voidrender
voidrender approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@voidrender voidrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@voidrender voidrender merged commit 1be157a into alchemyrpg:main Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voidrender voidrender voidrender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkJPerry @voidrender