Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated bookmarklet for support of game-data/always-prepeared-spells #54

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

oshinowo-stephen
Copy link
Contributor

Describe your changes

  • updated the src/bookmarklet.js to include game-data/always-prepared-spells into the character's classSpells.
  • exported src/bookmarklet.js into a minified verison: public/bookmarklet.min.js

D&D Beyond character link

https://www.dndbeyond.com/characters/102523122
https://www.dndbeyond.com/characters/96625992
https://www.dndbeyond.com/characters/99603501

Pre-review checklist

  • I have added a description of my changes
  • I have formatted my code with yarn format
  • I have added a link to a D&D Beyond character that can be used to test these changes
  • I have read the contributing guidelines
  • I agree to the code of conduct

Copy link
Collaborator

@thatbudakguy thatbudakguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this out and it did exactly what I hoped: the class-specific spells were downloaded when the bookmarklet was used, and they got converted to Alchemy spells as expected.

thank you so much for all your patience and work on this!

pinging @ioveracker as well so he's aware that Alchemy will have to do something similar on their side to replicate this functionality.

@voidrender
Copy link
Member

Awesome! Seems pretty clear from your code. We shouldn't have any problem replicating these extra calls on the Alchemy side.

I'll echo the sentiment here--appreciate your patience and work on this big improvement!

@voidrender voidrender merged commit 87aa59d into alchemyrpg:main Oct 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants