New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pab/2019 release #133
Open
pbroadbery
wants to merge
77
commits into
master
Choose a base branch
from
pab/2019-release
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pab/2019 release #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. Too verbose.
…write buggy code.
(might be able to do widths in future as well)
Returns the formal arguments on a map type form
NOTE: Fix to as early as poss.
- mostly call toPtr or leave as is
So Foo = Cross(Int, Int) will work
This helps for cases where we have a parameterised type, F, that has both Left(R) and Left(%), where R is some parameter. If we use F(%), then these two % values need to be distinguished.
given name from a list Main use case is debugging export lists.
It doesn't really make too much difference, but it's a logical thing to do.
- Only work with % expressions - check conditions before accepting
There's an option of returning something more interesting (eg. True, False, Don't know yet), so leaving as a function.
pbroadbery
force-pushed
the
pab/2019-release
branch
from
December 26, 2019 14:17
05a2e52
to
3ce114a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.